[Bug 530251] Review Request: gearbox - A collection of usable peer-reviewed robotics-related libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530251


Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx




--- Comment #1 from Ralf Corsepius <rc040203@xxxxxxxxxx>  2009-10-22 08:16:52 EDT ---
Some remarks:

* You install the shared libs to %{_libdir}/gearbox
Any particular reason for doing so rsp. why they should not be installed into
%{_libdir}?


* The doxygen call belongs into %build not into %install


* The *.pc's don't acknowledge the cross-dependencies between the libraries
this package consists of. 

For example: libhokuyo_aist.so* depends on libflexiport:
ldd usr/lib64/gearbox/libhokuyo_aist.so
...
 libflexiport.so.1.0.0 => not found
...
but hokuyo_aist.pc doesn't reflect this:
# cat usr/lib64/pkgconfig/hokuyo_aist.pc
...
Requires: 
Libs: -L/usr/lib64/gearbox  -lhokuyo_aist 
Cflags: -I/usr/include/gearbox

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]