Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=514221 David Lutterkort <lutter@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #13 from David Lutterkort <lutter@xxxxxxxxxx> 2009-10-21 06:55:36 EDT --- OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) See https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag OK - PreReq not used FIX - Source md5sum matches upstream Make tarball available upstream and change Source0 to a full URL to that tarball OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - Package builds successfully on i386 and x86_64 (mock) OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent OK - rpmlint is silent Please fix the Source0 issue before importing. APPROVED Please follow http://fedoraproject.org/wiki/CVSAdminProcedure and import the package. Close this bug as RAWHIDE once it's been successfully imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review