Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512608 Thomas Spura <spurath@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spurath@xxxxxxxxxxxxxxxxxxx | |de --- Comment #1 from Thomas Spura <spurath@xxxxxxxxxxxxxxxxxxxxx> 2009-10-20 20:48:23 EDT --- (In reply to comment #0) > > These should all be okay. Hmm, no ;) Just a few comments for now: - Could you explain in the spec what your patch does? - %global better than %define, see https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - rpmlint: no-binary error, because there is no binary and your package is *not* noarch. Does it work to make it noarch and install anything into %{_datadir}/mozilla/extensions/ ?? only-non-binary-in-usr-lib warning would be gone with that, too. I don't have the uncompressed-zip warning here (also 64-bit). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review