Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526126 --- Comment #20 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2009-10-20 19:45:09 EDT --- I've had a go at merging Andrew and Ignacio's specfiles, using Andrew's specfile as a base. I've also attempted to address some of the issues already raised in this review. Specfile: http://dmalcolm.fedorapeople.org/python3.spec SRPM: http://dmalcolm.fedorapeople.org/python3-3.1.1-2.fc11.src.rpm To ease review, a diff from Andrew's 3.1.1-1 specfile to my 3.1.1-2 specfile can be seen here: http://dmalcolm.fedorapeople.org/python3-from-3.1.1-1-to-3.1.1-2.diff I wrote a custom __find_provides hook, filtering away paths matching /usr/lib/python (which appears to require setting _use_internal_dependency_generator to 0). See http://dmalcolm.fedorapeople.org/find-provides-without-python-sonames.sh This successfully gets rid of the various _collectionsmodule.so etc provides lines: $ rpm -q --provides python3 python3 = 3.1.1-2.fc11 python3(x86-32) = 3.1.1-2.fc11 and thus my script to find collisions with the regular "python" rpms no longer detects any "Provides" collisions . Note that SONAME provides still work for regular libraries: $ rpm -q --provides python3-libs libpython3.1.so.1.0 python3-libs = 3.1.1-2.fc11 python3-libs(x86-32) = 3.1.1-2.fc11 See the %changelog in the specfile for the other changes. rpmlint output isn't clean yet (but it's getting late here): python3.i586: E: binary-or-shlib-defines-rpath /usr/lib/python3.1/lib-dynload/_sqlite3.so ['/usr/lib'] python3.i586: E: zero-length /usr/lib/python3.1/build_class.py python3-libs.i586: W: no-documentation python3-test.i586: W: no-documentation python3-test.i586: E: zero-length /usr/lib/python3.1/test/nullcert.pem python3-test.i586: E: script-without-shebang /usr/lib/python3.1/distutils/tests/Setup.sample python3-test.i586: W: uncompressed-zip /usr/lib/python3.1/test/zipdir.zip python3-tkinter.i586: W: no-documentation python3-tools.i586: E: script-without-shebang /usr/lib/python3.1/Demo/comparisons/patterns python3-tools.i586: E: script-without-shebang /usr/lib/python3.1/Demo/rpc/test python3-tools.i586: W: file-not-utf8 /usr/lib/python3.1/Demo/distutils/test2to3/setup.py python3-tools.i586: E: zero-length /usr/lib/python3.1/Tools/modulator/Templates/copyright python3-tools.i586: W: wrong-file-end-of-line-encoding /usr/lib/python3.1/Demo/turtle/tdemo_round_dance.py python3-tools.i586: W: file-not-utf8 /usr/lib/python3.1/Demo/rpc/README python3-tools.i586: E: script-without-shebang /usr/lib/python3.1/Tools/README python3-tools.i586: E: script-without-shebang /usr/lib/python3.1/Demo/scripts/newslist.doc python3-tools.i586: E: script-without-shebang /usr/lib/python3.1/Demo/md5test/foo python3-tools.i586: W: wrong-file-end-of-line-encoding /usr/lib/python3.1/Demo/turtle/tdemo_nim.py 7 packages and 0 specfiles checked; 10 errors, 8 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review