Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mysql-connector-net https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=177512 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-26 00:06 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 153f4bb405af5ae59565084a9ce6e1b1 mysql-connector-net-1.0.7-noinstall.zip 153f4bb405af5ae59565084a9ce6e1b1 mysql-connector-net-1.0.7-noinstall.zip.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. Issues: 1. Might change defattr from: %defattr(-,root,root) to %defattr(-,root,root,-) 2. rpmlint says: E: mysql-connector-net no-binary E: mysql-connector-net only-non-binary-in-usr-lib I think those can be ignored, as rpmlint doesn't know mono bins. W: mysql-connector-net wrong-file-end-of-line-encoding /usr/share/doc/mysql- connector-net-1.0.7/COPYING W: mysql-connector-net wrong-file-end-of-line-encoding /usr/share/doc/mysql- connector-net-1.0.7/EXCEPTIONS W: mysql-connector-net wrong-file-end-of-line-encoding /usr/share/doc/mysql- connector-net-1.0.7/CHANGES W: mysql-connector-net wrong-file-end-of-line-encoding /usr/share/doc/mysql- connector-net-1.0.7/README Should run a quick: %{__sed} -i 's/\r//' on those files? E: mysql-connector-net hardcoded-library-path in %{_prefix}/lib I think this is due to the core mono packaging? W: mysql-connector-net rpm-buildroot-usage %build rm -rf %{buildroot} That rm -rf %{buildroot} should at the top of 'install' and not 'build' ? E: mysql-connector-net-debuginfo empty-debuginfo-package Why no debuginfo files? Other mono packages have them. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review