Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmtp - MTP client library https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204140 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-25 23:38 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 5d22b16cb7e6a117cdf489669821df09 libmtp-0.0.15.tar.gz 5d22b16cb7e6a117cdf489669821df09 libmtp-0.0.15.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package doesn't own any directories other packages own. See below - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. OK - Should have subpackages require base package with fully versioned depend. Issues: 1. 0.0.19 is now available. 2. Might change the defattr from: %defattr(-, root, root) to %defattr(-, root, root,-) 3. rpmlint says: W: libmtp no-documentation W: libmtp-examples no-documentation Can be ignored. W: libmtp mixed-use-of-spaces-and-tabs Should clean up spec to only use tabs or spaces, not both. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review