Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519282 --- Comment #16 from Bradley <bbaetz@xxxxxxx> 2009-10-19 08:47:22 EDT --- Thanks for doing this - I was considering it before I saw that you were working on it. A couple of comments/bugs, though: * It doesn't work when built for x86_64 - /usr/bin/calibre adds /usr/lib/calibre to the libpath, but that should be lib64. Same for the plugin path. * I had problems building an unpatched calibre from upstream, because it wouldn't compile. You've added calibre-outputdev.patch to work around this, but I'm not sure that that is correct. calibre is documented as requiring poppler-0.12, which isn't in F11, and that function's signature has changed. It compiles, but it looks like it'll just recurse infinitely - rather than call the parent class's method it calls itself. I haven't worked out how to trigger that code, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review