Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515136 Mat Booth <fedora@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Mat Booth <fedora@xxxxxxxxxxxxxx> 2009-10-19 07:13:59 EDT --- (In reply to comment #7) > (In reply to comment #5) > > You mix $THIS_STYLE and %{this_style} variables, which is bad form so the > > guidelines say. You can easily fix this by replacing all instances of > > $RPM_BUILD_ROOT with %{buildroot} > > AFAIK What I did is perfectly acceptable. I didn't use both $RPM_BUILD_ROOT and > %{buildroot} - I only used the first. > > Moreover, all other macros are in the second style because they do not have an > equivalent in the first syntax. > > You can find a great number of spec files that do the same in Fedora CVS. > Fair enough. I'm happy to rubber-stamp this now. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review