Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529466 D Haley <mycae@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mycae@xxxxxxxxx --- Comment #4 from D Haley <mycae@xxxxxxxxx> 2009-10-18 01:35:11 EDT --- Some quick comments. Either (1) Add the following to the spec -- Do we need to make a separate tarball? or (2) notify upstream to have the licencing headers attached. If you do notify upstream, I note that some headers are LGPLv2+ -- would upstream be able to specify LGPLv2+ to all code? #Examples and tests dir contains copyrighted code, not marked with any lic header. | #Upstream has been notified to assist in re-licencing. | rm -f ./examples/charpoly.C ./examples/checksolve.C ./examples/det.C ./examples/doubledet.C ./examples/echelon.C \ ./examples/fields/ex-fields-archetype.C ./examples/fields/ex-fields.C ./examples/fields/modular-int.C \ ./examples/graph-charpoly.C ./examples/minpoly.C ./examples/rank.C ./examples/smith.C ./examples/solve.C \ ./examples/sparseelimdet.C ./examples/sparseelimrank.C ./examples/valence.C rm -f ./tests/test-bitonic-sort.C ./tests/test-block-ring.C ./tests/test-companion.C ./tests/test-ffpack.C \ ./tests/test-hilbert.C ./tests/test-last-invariant-factor.C ./tests/test-matrix-stream.C \ ./tests/test-modular-balanced-int.C ./tests/test-ntl-hankel.C ./tests/test-ntl-RR.C \ ./tests/test-ntl-sylvester.C ./tests/test-ntl-toeplitz.C ./tests/test-quad-matrix.C \ ./tests/test-rational-solver-adaptive.C ./tests/test-rational-solver.C \ /tests/test-scalar-matrix.C ./tests/test-smith-form-adaptive.C ./tests/test-smith-form-binary.C \ /tests/test-smith-form.C ./tests/test-smith-form-iliopoulos.C ./tests/test-subiterator.C \ /tests/test-subvector.C ./tests/test-toeplitz-det.C ./tests/test-triplesbb.C ./tests/test-zero-one.C \ /tests/test-zo.C As with givaro (bug #475065), the -config script does not emit properly if --cflags --lflags are both used. The following patch can be applied --- linbox-config.in 2008-06-14 11:21:00.000000000 +1000 +++ linbox-config.in.new 2009-10-10 16:35:45.000000000 +1100 @@ -55,11 +55,11 @@ ;; --cflags) - echo -I${includedir} @GMP_CFLAGS@ @NTL_CFLAGS@ @GIVARO_CFLAGS@ @SACLIB_CFLAGS@ @LIDIA_CFLAGS@ + echo -n " -I${includedir} @GMP_CFLAGS@ @NTL_CFLAGS@ @GIVARO_CFLAGS@ @SACLIB_CFLAGS@ @LIDIA_CFLAGS@" ;; --libs) - echo -L${libdir} -llinbox @LIDIA_LIBS@ @NTL_LIBS@ @GIVARO_LIBS@ @SACLIB_LIBS@ @GMP_LIBS@ @BLAS_LIBS@ + echo -n " -L${libdir} -llinbox @LIDIA_LIBS@ @NTL_LIBS@ @GIVARO_LIBS@ @SACLIB_LIBS@ @GMP_LIBS@ @BLAS_LIBS@" ;; *) @@ -69,5 +69,6 @@ esac shift done +echo exit 0 On Linux spiderbox 2.6.27.37-170.2.104.fc10.i686, I am getting rpmlint errors. If you don't have access to this arch, you can use the test machines (https://fedoraproject.org/wiki/Test_Machine_Resources_For_Package_Maintainers) linbox.i386: E: shlib-with-non-pic-code /usr/lib/liblinboxsage.so.0.0.0 linbox.i386: W: shared-lib-calls-exit /usr/lib/liblinboxsage.so.0.0.0 exit@xxxxxxxxx linbox.i386: E: shlib-with-non-pic-code /usr/lib/liblbdriver.so.0.0.0 linbox.i386: W: shared-lib-calls-exit /usr/lib/liblbdriver.so.0.0.0 exit@xxxxxxxxx 4 packages and 0 specfiles checked; 2 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review