Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516533 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review+ --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-10-17 23:15:55 EDT --- Review of globus-gatekeeper: Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1752463 YES: rpmlint. rpmlint globus-gatekeeper.spec ../SRPMS/globus-gatekeeper-5.0-1.fc11.src.rpm ../RPMS/x86_64/globus-gatekeeper-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. clean. YES: Package name YES: Spec file name. YES: Follows globus guidelines. YES: YES ASL2.0 YES: LICESNSE file included. YES: Spec in english YES: Spec is legible. YES: Source matches. $ diff -r --brief globus_gatekeeper-5.0 ~/globus/src/gt4.2.1-all-source-installer/source-trees/gatekeeper/source/ Only in globus_gatekeeper-5.0: GLOBUS_LICENSE $ diff -r --brief gt4.2.1-all-source-installer/source-trees/gatekeeper/setup ~/rpmbuild/SOURCES/globus_gatekeeper_setup-2.2 Only in /home/steve/rpmbuild/SOURCES/globus_gatekeeper_setup-2.2: GLOBUS_LICENSE which are expected. YES: Builds as per koji above. YES: Builds on all archs as per koji above. YES: BuildRequires are sensible. YES: No locales present. YES: ldconfig not needed. YES: No system libs. YES: It owns its own directories. YES: Permissions are correct. YES: %clean rm %buildroot YES: consistant use of macros. YES: Contains code. YES: No large documents. YES: %doc not needed at runtime. YES: no devel pcakge. YES: No static files. YES: No .la files are present. YES: No gui YES: does not own files/directories owned elsewhere. YES: %install does a rm %buildroot YES: utf8. Looks good and even starts. APPROVED Steve. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review