Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Finance-YahooQuote - Perl interface to get stock quotes from Yahoo! Finance Alias: finance-YahooQuote https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207846 ------- Additional Comments From chris.stone@xxxxxxxxx 2006-09-25 18:12 EST ------- Warren: I tried to build this under mock with %check enabled and a BR of perl(HTTP::Request::Common). This also results in a failure and warnings mentioned in the build log of missing packages. By using a BR of perl(HTTP::Request), this fixes the problem. perl(HTTP::Request) needs to be added to the BR in order for %check to function and should be added even though it is not used for official builds. A developer who enables the %check section would not automatically know this otherwise. The build log also indicates that rpm is adding a Requires of perl(HTTP::Request::Common), however, when I tried using this for a BR, it fails and the following warnings are shown: Warning: prerequisite HTML::Parser 2.2 not found. Warning: prerequisite HTTP::Request 1.23 not found. Warning: prerequisite LWP::UserAgent 1.62 not found. These packages do not show up as being required by rpm. Therefore, I think a "Requires: perl(HTTP::Request)" also needs to be added to the spec file. Please add this unless you can show that it is not required. ==== Review Checklist ==== - rpmlint output clean - package named according to package naming guidelines - filename matches spec's %{name} - package meets packaging guidelines - package licensed with opensource compatible license - license in spec matches actual license - license included in %doc - spec written in American english - spec file legible - sources match upstream 844d26ef02f16216840aac5815a6a6a7 Finance-YahooQuote-0.21.tar.gz - package successfully compiles and builds on FC5 x86_64 - package does not contain locales - package does not contain shared libraries/static libraries/pkgconfig files or any other files required for a devel subpackage - package is not relocatable - package does not contain duplicate files in %files - permissions on files set properly - package contains proper %clean section - macro usage is consistent - package contains code - no large documentation files - files in %doc do not affect runtime - no need for .desktop files === MUST === - Please address concerns I have about BuildRequires and Requires issues I mention above. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review