Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: klamav - Clam Anti-Virus on the KDE Desktop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193867 ------- Additional Comments From cgoorah@xxxxxxxxxxxx 2006-09-25 17:24 EST ------- #1: remove zlib-devel as BuildRequires since curl-devel requires openssl-devel and the later requires zlib-devel #2: replace "Requires: %{_bindir}/freshclam" by "Requires: clamav-update" #3: In %post and %postun replace if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi by %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : since "|| :" causes the command to exit with a successful exit status whether or not the command worked. #4 debug rpm: chitlesh(SPECS)[0]$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/klamav-debuginfo-0.38-2.i386.rpm E: klamav-debuginfo script-without-shebang /usr/src/debug/klamav-0.38/src/klammail/client.c E: klamav-debuginfo script-without-shebang /usr/src/debug/klamav-0.38/src/klammail/options.c E: klamav-debuginfo script-without-shebang /usr/src/debug/klamav-0.38/src/klammail/options.h E: klamav-debuginfo script-without-shebang /usr/src/debug/klamav-0.38/src/klammail/clamdmail.c E: klamav-debuginfo script-without-shebang /usr/src/debug/klamav-0.38/src/klammail/treewalk.c Solution: in %install, add chmod 644 src/klammail/*.{c,h} #5: rpmlint rpm chitlesh(SPECS)[0]$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/klamav-0.38-2.i386.rpm W: klamav dangling-relative-symlink /usr/share/doc/HTML/en/klamav02/common ../common /tmp/klamav-0.38-2.i386.rpm.20210/usr/share/applications/fedora-klamav.desktop: warning: file contains key "DocPath", this key is currently reserved for use within KDE, and should in the future KDE releases be prefixed by "X-" Ignore both. /tmp/klamav-0.38-2.i386.rpm.20210/usr/share/applications/fedora-klamav.desktop: warning: boolean key "Terminal" has value "0", boolean values should be "false" or "true", although "0" and "1" are allowed in this field for backwards compatibility Solution (one line): %{__sed} -i.orig -e '/^Terminal/s|^.*$|Terminal=false|' \ ${RPM_BUILD_ROOT}%{_datadir}/applnk/Utilities/%{name}.desktop %{__rm} -f ${RPM_BUILD_ROOT}%{_datadir}/applnk/Utilities/%{name}.desktop.orig before "desktop-file-install --vendor fedora \" .. #6: in %doc, drop NEWS, because it's empty -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review