Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516534 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-10-16 17:15:00 EDT --- Comment: The end result of this huge number of packages is excellent but the work the process to get to that point..... It's worth while for sure. Liked the article. http://www.isgtw.org/?pid=1002049 Review of globus-gram-job-manager-callout-error Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1750703 NO: rpmlint $ rpmlint globus-gram-job-manager-callout-error.spec ../SRPMS/globus-gram-job-manager-callout-error-0.2-1.fc11.src.rpm ../RPMS/x86_64/globus-gram-job-manager-callout-error-* ../RPMS/noarch/globus-gram-job-manager-callout-error-doc-0.2-1.fc11.noarch.rpm globus-gram-job-manager-callout-error-debuginfo.x86_64: E: description-line-too-long This package provides debug information for package globus-gram-job-manager-callout-error. globus-gram-job-manager-callout-error-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 1 errors, 1 warnings. Just the trivial line to long but its easy to fix, presumably can be added to your .spec generator. YES: pkg name good. YES: spec file name good. YES: Meets globus guidelines. YES: License YES: License in .spec file. YES: Licesne files in package YES: American English. YES: Spec legible. YES: $ diff -r --brief globus_gram_job_manager_callout_error-0.2 ~/globus/src/gt4.2.1-all-source-installer/source-trees/gram/jobmanager/callout_error/ Only in globus_gram_job_manager_callout_error-0.2: GLOBUS_LICENSE which is expected. YES: Builds fine, see koji above. YES: Builds on all YES: BR good, in koji. YES: No locales present. YES: ldconfig called suitably. YES: No system libs. YES: Not relocatable. YES: Owns directories or pulls them in. YES: No double enties. YES: All defattr. YES: build root removed on clean. YES: Consistant use of macros. YES: Yes there is code if not a lot. YES: %doc not needed runtime. YES: devel package good. YES: devel requires libs. $ rpm -pq --requires globus-gram-job-manager-callout-error-devel-0.2-1.fc11.x86_64.rpm /usr/bin/pkg-config globus-common-devel(x86-64) >= 3 globus-core(x86-64) >= 4 globus-gram-job-manager-callout-error(x86-64) = 0.2-1.fc11 YES: no .la files present. YES: no gui. YES: utf8 Just the trivial description. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review