Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529024 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-10-16 14:43:33 EDT --- Some quick comments: - append %{?dist} to the release number - add --disable-static to %{configure} - add the following line to the build section in order to remove .la files: find $RPM_BUILD_ROOT -name "*.la" -delete - set the permissions of the .py files to 0755 - you should replace the existing python shebangs according to https://fedoraproject.org/wiki/Features/SystemPythonExecutablesUseSystemPython - remove the empty files (NEWS, ChangeLog) from %doc - add rm -rf $RPM_BUILD_ROOT/%{_docdir}/ to the %build section and remove %{_docdir}/GNUsTicker from %files as the folder only contains the files already added to %doc $ rpmlint /var/lib/mock/fedora-11-x86_64/result/GNUsTicker-* GNUsTicker.src: W: no-cleaning-of-buildroot %install GNUsTicker.src: W: no-buildroot-tag GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/parser.py 0644 /usr/bin/env GNUsTicker.x86_64: E: zero-length /usr/share/doc/GNUsTicker-0.1.1/NEWS GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/gtkutils.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/feedparser.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/setup.py 0644 /usr/bin/env GNUsTicker.x86_64: W: devel-file-in-non-devel-package /usr/libexec/GNUsTicker/GNUsTicker.a GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/utils.py 0644 /usr/bin/env GNUsTicker.x86_64: E: zero-length /usr/share/doc/GNUsTicker/ChangeLog GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/feed_plugins/fake_rss.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/feed_plugins/rss.py 0644 /usr/bin/env GNUsTicker.x86_64: E: zero-length /usr/share/doc/GNUsTicker-0.1.1/ChangeLog GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/feeds.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/configuration.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/globaldata.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/widgets/scrolling.py 0644 /usr/bin/env GNUsTicker.x86_64: E: zero-length /usr/share/doc/GNUsTicker/NEWS GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/gtkforms.py 0644 /usr/bin/env GNUsTicker.x86_64: E: non-executable-script /usr/libexec/GNUsTicker/feeds_configuration.py 0644 /usr/bin/env 3 packages and 0 specfiles checked; 17 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review