Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528847 --- Comment #5 from Matt Domsch <matt_domsch@xxxxxxxx> 2009-10-15 21:15:53 EDT --- A few more items: By changing the name, you can drop the define real_name and its use in %setup. https://fedoraproject.org/wiki/Licensing says that the License tag should be: License: GPL+ because no version is specified in the source. I think omitting the [fg]eplot and nplaunch files is wrong. You can chmod them 0644 and then include them in %doc. And bump the Release number, from 1.2 to 2, in case anyone happens to have the older release somehow. Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review