Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=504479 Jan Klepek <jan.klepek@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Jan Klepek <jan.klepek@xxxxxx> 2009-10-15 16:38:38 EDT --- - license ok - rpmlint complaining, however it could be safely ignored - location correct - macros usage correct - md5sum of source correct - build ok - guidelines ok - ruby specific guidelines ok - naming ok as new version (0.4.2) was released, please update package to this version, hope following diff between yours and mine spec file will help. --- SPECS/rubygem-cucumber.spec.old 2009-10-15 22:16:05.912579939 +0200 +++ SPECS/rubygem-cucumber.spec 2009-10-15 22:29:50.804448521 +0200 @@ -47,6 +47,11 @@ # Remove zero-length documentation files find $RPM_BUILD_ROOT%{gemdir}/doc/%{gemname}-%{version} -empty -delete # Manifest.txt is now zero-lenght +rm $RPM_BUILD_ROOT%{geminstdir}/Manifest.txt + +# remove non-needed git repo files +rm $RPM_BUILD_ROOT%{geminstdir}/.gitattributes +find $RPM_BUILD_ROOT%{geminstdir} -name ".gitignore" -delete %clean @@ -58,20 +63,19 @@ %{_bindir}/cucumber %dir %{geminstdir} %{geminstdir}/bin -%{geminstdir}/config %{geminstdir}/features %{geminstdir}/gem_tasks %{geminstdir}/lib %{geminstdir}/rails_generators %{geminstdir}/spec -%{geminstdir}/cucumber.yml +%{geminstdir}/cucumber.* %{geminstdir}/Rakefile +%{geminstdir}/VERSION.yml %doc %{geminstdir}/examples %doc %{gemdir}/doc/%{gemname}-%{version} %doc %{geminstdir}/History.txt -%doc %{geminstdir}/License.txt -%doc %{geminstdir}/Manifest.txt -%doc %{geminstdir}/README.txt +%doc %{geminstdir}/LICENSE +%doc %{geminstdir}/README.rdoc %{gemdir}/cache/%{gemname}-%{version}.gem %{gemdir}/specifications/%{gemname}-%{version}.gemspec conclusion: approved when package updated to 0.4.2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review