Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498218 Thomas Spura <spurath@xxxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spurath@xxxxxxxxxxxxxxxxxxx | |de --- Comment #2 from Thomas Spura <spurath@xxxxxxxxxxxxxxxxxxxxx> 2009-10-15 09:24:27 EDT --- Just a few comments, not a review: This bug should block your tracker bug and not depend on it. The tracker bug can only be closed, if all bugs 'blocking' the tracker bugs are closed. If they depend all on the tracker, they all can only be closed, if the tracker gets closed first. Are you sure about the version generation? See [1]. So it should have the name picturetile-0-1.20050314.fc10.src.rpm, isn't it? I'm not sure about this, too, but simply using the date as a version number 'looks bad'.^^ e.g. from the guidelines: kismet-0-0.1.20040110svn (this is a pre-release, svn checkout of kismet) kismet-0-0.2.20040110svn (this is a bugfix to the previous package) kismet-0-0.3.20040204svn (this is a new svn checkout, note the increment of %{X}) kismet-1.0-1 (this is the formal release of kismet 1.0) Of course, there will maybe never been any real version, but how about using always version 0 and append the date after the release number? [1] https://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review