Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527996 --- Comment #6 from Steve Traylen <steve.traylen@xxxxxxx> 2009-10-15 03:43:52 EDT --- Hi Orion, Review of jempbox: MUST: YES: $ rpmlint jempbox.spec ../SRPMS/jempbox-0.8.0-3.fc11.src.rpm ../RPMS/x86_64/jempbox-* jempbox.spec:85: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} jempbox.src:85: W: libdir-macro-in-noarch-package (main package) %attr(-,root,root) %{_libdir}/gcj/%{name} 3 packages and 1 specfiles checked; 0 errors, 2 warnings. which is expected because of the %if case with gcj. NO: Package is not named correctly. The package contains /usr/share/java/jempbox-0.8.0-incubating.jar only so in principal should be called jempbox-0.8.0-incubating as per https://fedoraproject.org/wiki/Packaging:Java#Package_naming but I think really a jempbox.jar symlink should be made with a (cd %{buildroot}%{_javadir} && for jar in *-%{version}*; do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"`; done) or similar. I'll stop the review now since depending on how this is fixed changes other elements of the review. For an example package that does the symlinking to a generic version of the jar see bug #521895 and if you have time to review this that would be great. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review