Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516520 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review+ --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-10-14 16:28:08 EDT --- Review of globus-data-conversion: koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1746665 MUST: yes: $ rpmlint globus-data-conversion.spec ../SRPMS/globus-data-conversion-2.1-1.fc11.src.rpm ../RPMS/x86_64/globus-data-conversion-* globus-data-conversion-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings. which is fine. yes: Package name - globus guidelines yes: Spec File name - globus guidelines yes: Packaging guidelines yes: Apache 2.0 yes: .spec ASL 2.0 yes: GLOBUS_LICENSE included. yes: american english. yes: Upstream source matches. $ diff -r --brief gt4.2.1-all-source-installer/source-trees/data_conversion/source ~/rpmbuild/SOURCES/globus_data_conversion-2.1 Only in /home/steve/rpmbuild/SOURCES/globus_data_conversion-2.1: GLOBUS_LICENSE which is expected. yes: builds as per koji build above. yes: locales not present. yes: Calls ldconfig appropriate yes: No system libs included. yes: not relocatable. yes: All files and directories created in the package are owned. yes: files not listed twice. yes: defattr used everywhere. yes: Buildroot is removed in %clean. yes: consistant macros yes: no large docs. yes: docs not needed runtime. yes: headers in -devel file. yes: libs correctly in -devel package. yes: main package is needed by devel package. yes: no .la files present. yes: no gui. yes: does not own files belonging to other packages. yes: buildroot removed in %install. yes: utf8 APPROVED Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review