[Bug 526746] Review Request: yaz - Z39.50/SRW/SRU programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526746


Martin Gieseking <martin.gieseking@xxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |martin.gieseking@xxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |martin.gieseking@xxxxxx
               Flag|                            |fedora-review+




--- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx>  2009-10-14 15:29:31 EDT ---
The package is in pretty good shape. I couldn't find any issues to be fixed, so
we can directly finish here. :)

$ rpmlint /var/lib/mock/fedora-11-x86_64/result/*.rpm
5 packages and 0 specfiles checked; 0 errors, 0 warnings.


---------------------------------
keys used in following checklist:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.

[+] MUST: The spec file name must match the base package %{name}.

[+] MUST: The package must meet the Packaging Guidelines.

[+] MUST: The package must be licensed with a Fedora approved license.
    - BSD (three clause variant)

[+] MUST: The License field in the package spec file must match the actual
license.

[+] MUST: File containing the text of the license(s) for the package must be
included in %doc.
    - LICENSE added to %doc

[+] MUST: The spec file must be written in American English.

[+] MUST: The spec file for the package MUST be legible.

[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
    $ sha1sum yaz-3.0.49.tar.gz*
    351f7b2b3b0fb565ff65c6b283462780bf4a6953  yaz-3.0.49.tar.gz
    351f7b2b3b0fb565ff65c6b283462780bf4a6953  yaz-3.0.49.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    koji scratch build:
    https://koji.fedoraproject.org/koji/taskinfo?taskID=1746478

[.] MUST: If the package does not successfully compile, build or work ...

[+] MUST: All build dependencies must be listed in BuildRequires.

[.] MUST: The spec file MUST handle locales properly.
    - no locales

[+] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.

[.] MUST: If the package is designed to be relocatable, ...
    - not relocatable

[+] MUST: A package must own all directories that it creates. 

[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.

[+] MUST: Permissions on files must be set properly.

[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}.

[+] MUST: Each package must consistently use macros.

[+] MUST: The package must contain code, or permissable content.

[.] MUST: Large documentation files must go in a -doc subpackage.
    - no large docs

[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.

[+] MUST: Header files must be in a -devel package.

[.] MUST: Static libraries must be in a -static package.
    - no static libs built

[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
    - devel package contains yaz.pc and Requires: pkgconfig

[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

[+] MUST: devel packages must require the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
    - libyaz-devel requires libyaz

[+] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
    - .la files removed

[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file.
    - no GUI

[+] MUST: Packages must not own files or directories already owned by other
packages.

[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}.

[+] MUST: All filenames in rpm packages must be valid UTF-8.


[+] SHOULD: The reviewer should test that the package builds in mock.
    - builds in mock

[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
    - builds in koji

[+] SHOULD: The reviewer should test that the package functions as described.
    - seems to work as expected

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.

[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

[+] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.

------------------------
The package is APPROVED.
------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]