Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226066 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cwickert@xxxxxxxxxxxxxxxxx --- Comment #2 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-10-12 13:10:40 EDT --- Sorry, but you missed a couple of issues: - md5sum is 7dcdad1c10daea872cb3355af414b2ca, both for upstream as well as for the file from lookaside cache - timestamps not preserved during iconv - timestamp of index.theme not preserved during install - permissions are not - /usr/share/ hardcoded, although commented out - devel package missing "Requires: xorg-x11-proto-devel" - why do we still inherit Bluecurce in index.theme? - make is not verbose, so RPM_OPT_FLAGS cannot be verified CC cursor.lo CC display.lo CC file.lo CC library.lo CC xlib.lo CCLD libXcursor.la I know you are doing a lot of reviews, but IMO the quality must not suffer from the quantity. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review