Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528150 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-10-10 05:31:24 EDT --- Some initial comments: - according to the source file headers, the license is GPLv3+ - The files src/util.* are licensed under GPLv2+. You should ask upstream if this is intended. - in Source0, give a full URL to the source tarball - remove the final dot in Summary - append CFLAGS="$RPM_OPT_FLAGS" CPPFLAGS="$RPM_OPT_FLAGS" to %configure in order to get the debuginfo package build correctly - use macros in the %files section and add the doc files properly - drop INSTALL and the empty files from %doc - drop the locale file from %files - see the packaging guidelines how to install the .desktop file (http://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files) $ rpmlint /var/lib/mock/fedora-11-x86_64/result/invulgotracker-* invulgotracker.src: W: summary-ended-with-dot Tasks & projects tracking tool. invulgotracker.x86_64: W: summary-ended-with-dot Tasks & projects tracking tool. invulgotracker.x86_64: E: zero-length /usr/doc/invulgotracker/NEWS invulgotracker.x86_64: E: zero-length /usr/doc/invulgotracker/README invulgotracker.x86_64: W: non-standard-dir-in-usr doc invulgotracker-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 0 specfiles checked; 3 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review