[Bug 528096] Review Request: kmagnet - KDE puzzle game with built in editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528096


Ryan Rix <phrkonaleash@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kevin@xxxxxxxxxxxxxxxx      |nobody@xxxxxxxxxxxxxxxxx




--- Comment #4 from Ryan Rix <phrkonaleash@xxxxxxxxx>  2009-10-10 01:46:05 EDT ---
>You have to run desktop-file-validate for your .desktop file.

Addressed.

>So it's enough to have kdegames-devel in BuildRequires.

[rrix@TheSwan rpmbuild]$ rpmlint RPMS/i586/kmagnet-0.02-2.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

I assume that because rpmlint errs on Requires: kdelibs4, that the soname
dependencies autogenerate that Requires. That leaves me with only a
BuildRequires on kdegames-devel. Is this correct?


* Fri Oct 9 2009 Ryan Rix < phrkonaleash [AT] gmail dot com > - 0.02-2
- Fixed Requires and BuildRequires
- Removed VERBOSE=1 from Makefile
- Sane use of macros in files section
- Added documentation
- Added icon code snippets

[rrix@TheSwan rpmbuild]$ rpmlint RPMS/i586/kmagnet-0.02-2.fc11.i586.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1739167

Updated SPEC and SRPM:
http://rrix.fedorapeople.org/kmagnet/kmagnet.spec
http://rrix.fedorapeople.org/kmagnet/kmagnet-0.02-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]