Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519282 --- Comment #6 from José Matos <jamatos@xxxxxxxx> 2009-10-09 15:00:02 EDT --- You have proved to show and understanding of the packaging guidelines. That is good. :-) Now for some small issues with this package: 1) please add the the directory %{python_sitelib}/%{name}/ to files as Michael pointed above. In this case it enough to replace %{python_sitelib}/%{name}/* with %{python_sitelib}/%{name} 2) there is a missing BuildRequires python-mechanize in the spec file 3) I notice that you use lots of versioned (Build)Requires, are those real dependencies, I know that calibre requires python-2.6 but I am not sure about the others. Just asking here. 4) one small suggestion, when you declare the egg-info file I would suggest to use %{python_sitelib}/%{name}-%{version}-*.egg-info instead of %{python_sitelib}/%{name}-%{version}-py2.6.egg-info In this case this will work for python-2.7 without any need to change to spec file just for this detail. For the moment this enough. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review