Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528149 --- Comment #4 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-10-09 11:25:48 EDT --- Thanks. Full review below. Only one issue. - licensing fine - naming fine - version fine - release fine - builds fine - macros fine - files good except marking piccolo2d as %doc - X rpmlint output: $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/piccolo2d-1.3-0.svn689.fc11.noarch.rpm piccolo2d.noarch: W: no-documentation piccolo2d.noarch: W: non-conffile-in-etc /etc/maven/fragments/piccolo2d The latter warning is okay to ignore but please mark license-piccolo.txt as %doc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review