Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528125 --- Comment #4 from Michal Ingeli <mi@xxxxx> 2009-10-09 08:49:27 EDT --- (In reply to comment #2) > 1.) Please do not repeat %attr-s, use %defattr instead, such as > %defattr(0644,root,root,0755) Hope it's fixed. I left them only on necessary places, that may be broken in original package. > 2.) Don't duplicate RPM's work when installing documentation. > Replace > > cp -rp usr/share/doc/* %{buildroot}/%{_defaultdocdir}/ > ... > %attr(644,root,root) %doc %{_defaultdocdir}/*/* > > with something like "%doc usr/share/doc/*" done (In reply to comment #3) > 3.) mysql-zrm-socket-server service runs as mysql:mysql user. Shouldn't your > files in /var be writable by that user? Changed ownership of /var/log/mysql-zrm, but not /var/lib/mysql-zrm. I believe that it's dependent on local backup settings, which user will run backup jobs from crontab. > 4.) mysql-zrm-socket-server xinetd service is enabled by default. Should be > disabled. done Spec URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm.spec SRPM URL: http://v3.sk/~xyzz/rpm/MySQL-zrm/MySQL-zrm-2.1.1-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review