Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528125 Lubomir Rintel <lkundrak@xxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lkundrak@xxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |lkundrak@xxxxx Flag| |fedora-review? --- Comment #2 from Lubomir Rintel <lkundrak@xxxxx> 2009-10-09 06:37:18 EDT --- 1.) Please do not repeat %attr-s, use %defattr instead, such as %defattr(0644,root,root,0755) 2.) Don't duplicate RPM's work when installing documentation. Replace cp -rp usr/share/doc/* %{buildroot}/%{_defaultdocdir}/ ... %attr(644,root,root) %doc %{_defaultdocdir}/*/* with something like "%doc usr/share/doc/*" -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review