Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528096 Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomasj@xxxxxxxxxxxxxxxxx --- Comment #1 from Thomas Janssen <thomasj@xxxxxxxxxxxxxxxxx> 2009-10-09 03:06:00 EDT --- A few quick comments: gcc-c++ is part of the minimal build environment. http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRequires cmake is even in F10 >= 2.6.0 and that's the oldest supported release. You can remove both. Your >= versioning is unneeded since we ship versions greater than those the program needs in all supported fedora versions. (BuildRequires: qt4-devel >= 4.4.0 kdelibs4-devel >= 4.1 kdegames-devel >= 4.4.0 Requires: kdelibs4 >= 4.1 qt4 >= 4.4.0) kdelibs requires qt anyways, so no need for the qt4 in Requires Same in buildrequires, kdelibs4-devel requires qt4-devel. And kdegames-devel requires kdelibs4-devel. So it's enough to have kdegames-devel in BuildRequires. No need for VERBOSE=1 with make. Dont use full path in % files section. Use macros. %{_kde4_docdir}/HTML/en/%{name}/* %doc is empty. Fill it with AUTHORS ChangeLog README COPYING TODO You have to run desktop-file-validate for your .desktop file. You're missing icon code snippets: %post touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : %postun if [ $1 -eq 0 ] ; then touch --no-create %{_kde4_iconsdir}/hicolor &>/dev/null gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &>/dev/null || : update-desktop-database -q &> /dev/null update-mime-database %{_kde4_datadir}/mime &> /dev/null fi %posttrans gtk-update-icon-cache %{_kde4_iconsdir}/hicolor &> /dev/null || : update-desktop-database -q &> /dev/null update-mime-database %{_kde4_datadir}/mime &> /dev/null -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review