Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502614 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mtasaka@xxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #39 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-08 14:11:24 EDT --- For -6: * Again about sed - Well, still I would like to see more smart usage of sed (if you want to use sed instead of patch), like: -------------------------------------------------------- sed -i.path \ -e '/mkdir.*lib-dynload/d' \ -e '/cp/s|lib-dynload||' \ python/Makefile.* sed -i.soname \ -e 's|\(.*ln -fs.*/\)\(libstfl\.so\)$|\1\2\n\1\$(SONAME)|' \ Makefile sed -i.ldflags -e 's|\(-shared\)|\1 \$(LDLIBS)|' Makefile sed -i.path -e 's|libdir=.*|libdir=%{_libdir}|' stfl.pc.in sed -i.cflags -e 's|-Os||' Makefile -------------------------------------------------------- There may be more smart ways. ! By the way -------------------------------------------------------- sed -i 's,libdir=${exec_prefix}/lib,libdir=${exec_prefix}/${libdir},' stfl.pc.in -------------------------------------------------------- is wrong. "libdir=${exec_prefix}/${libdir}" is invalid because ${libdir} cannot be defined with this line ( try "$ pkg-config --libs stfl " and what returns ) * Redundant macros - Empty %doc still remains (in -perl subpackage) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review