Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527840 Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #3 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-10-08 13:12:03 EDT --- (In reply to comment #2) > OK - Package obey's FHS standard (except for 2 exceptions) What do you mean with that? If you are referring to the unversioned libs in %{_libdir}/%{name}-0, which according to our guidelines should be in the -devel package: these are the plugins. They are unversioned as they are not used by anything other than parole. > Two of the files are LGPLv2+, but that should make the package still GPLv2+. > (parole-subtitle-encoding.[ch]) Right, the whole app itself still is GPLv2+ > 1. A few optional packages we might be able to build with: > > checking for optional package libnotify >= 0.4.1... not found > checking for optional package taglib >= 1.4... not found Oops, obviously I didn't look close enough at the build logs. One was a typo (libnotify instead of libnotify-devel), the other was simply missing (taglib-devel >= 1.4). I have fixed both in the spec: http://cwickert.fedorapeople.org/review/parole.spec > Let me know if you would like a co-maintainer, happy to help. Great, that would be helpful. I'll add you as owner. New Package CVS Request ======================= Package Name: parole Short Description: Media player for the Xfce desktop Owners: cwickert kevin Branches: F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review