Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527402 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.gieseking@xxxxxx --- Comment #1 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-10-07 11:45:24 EDT --- A couple of comments: - you must probably add Requires: gtest >= 1.4.0 because it's not recognized automatically - is the required gtest version always greater or equal than the version of gmock? If not, I'd suggest to replace BR:gtest-devel >= %{version} by BR:gtest-devel >= 1.4.0 - the lines in the %description section shouldn't exceed 80 characters - add the version and revision number to the first line of the changelog entry: Sun Oct 4 2009 Tejas Dinkar <tejas@xxxxxx> - 1.4.0-1 $ rpmlint /home/mgieseki/rpmbuild/RPMS/i586/gmock-* gmock.i586: E: description-line-too-long Inspired by jMock, EasyMock, and Hamcrest, and designed with C++'s specifics in mind, gmock.i586: E: description-line-too-long Google C++ Mocking Framework (or Google Mock for short) is a library for writing and using C++ mock classes. Google Mock: gmock.i586: W: no-version-in-last-changelog gmock.i586: W: shared-lib-calls-exit /usr/lib/libgmock.so.0.0.0 _exit@xxxxxxxxx gmock-debuginfo.i586: W: no-version-in-last-changelog gmock-devel.i586: W: no-version-in-last-changelog gmock-devel.i586: W: no-documentation 3 packages and 0 specfiles checked; 2 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review