Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=502614 --- Comment #35 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-10-06 04:31:41 EDT --- (In reply to comment #34) > Use a patch instead of sed, since sed will quietly do nothing if the makefile > changes in the future, whereas patch will fail and let you know. I always think that even if patches created against the older version "seem" to apply to the newer version "correctly", it does not guarantee that the modified code is what we expect and we should check them _anyway_ so I don't see so much advantage on using patch over using sed for this purpose > I'd say you have to modify the default CFLAGS: > export CFLAGS += -I. -Wall -Os -ggdb -D_GNU_SOURCE -fPIC > You were probably failing due to the missing -I. -D_GNU_SOURCE which modifies > compilation behaviour when you tried > export CFLAGS += $(RPM_OPT_FLAGS) > Just replace this occurrence with > export CFLAGS += -I. -D_GNU_SOURCE -fPIC > You need to do this, since -Os will override the default Fedora optimization > flag (-O2). Well, I ignored this because for me -Os and -O2 doesn't differ so much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review