Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526855 David Nalley <david@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@xxxxxxx --- Comment #2 from David Nalley <david@xxxxxxx> 2009-10-05 23:02:42 EDT --- First of all, thanks, this looks like a great aid to bacula users. I can not sponsor you but a few comments to help you clean things up a bit: ValidateDateTime.php in source is a bundled library - and needs to use a system lib. Unfortunately a quick search didn't reveal this library in Fedora's package repository. A google search for the function names only reveals a pointer to your software, so this might be something that really is part of webacula, but given it's purpose I doubt it. https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries If I were reviewing your packages I'd evaluate that (along with the other libraries) on these factors first: 1. Does the library have a separate repository 2. Does or could any other application use this library A yes answer to either makes me lean towards it being a bundled library and needing to be packaged separately. rpmlint: [ke4qqq@nalleyt43 SRPMS]$ rpmlint webacula-3.2.1-1.fc11.src.rpm webacula.src: W: strange-permission webacula_clean_tmp_files 0775 You may want to change that to 755, but don't really see that as a blocker. [ke4qqq@nalleyt43 noarch]$ rpmlint webacula-3.2.1-1.fc11.noarch.rpm webacula.noarch: E: htaccess-file /usr/share/webacula/html/.htaccess webacula.noarch: E: htaccess-file /usr/share/webacula/install/.htaccess webacula.noarch: E: htaccess-file /usr/share/webacula/html/test_mod_rewrite/.htaccess webacula.noarch: E: htaccess-file /usr/share/webacula/docs/.htaccess webacula.noarch: E: htaccess-file /usr/share/webacula/application/.htaccess webacula.noarch: E: htaccess-file /usr/share/webacula/languages/.htaccess 1 packages and 0 specfiles checked; 6 errors, 0 warnings. content from .htaccess files should ideally be consolidated in your .conf file and the file removed during installation. Also consider writing an INSTALL.fedora document much like exists for debian. Essentially you want to take them from the point right after 'yum install webacula' completes, to having a working system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review