Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525831 Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Emmanuel Seyman <emmanuel.seyman@xxxxxxxxxxxxxxxx> 2009-10-05 19:04:52 EDT --- Review: + package builds in mock (dist-f13 i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1729479 + rpmlint issues a warning for the RPMS, is silent for the SRPM vim-perl-tt2.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + source files match upstream url 3e70d82171456550855a8b9612226c11 tt2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is not included in package. + %doc is not present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does not create any directories. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Looks good to me (shame about the lack of documentation, though). APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review