Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526204 Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora-fonts-bugs-list@redh | |at.com AssignedTo|nobody@xxxxxxxxxxxxxxxxx |nicolas.mailhot@xxxxxxxxxxx Flag|fedora-review? |needinfo?(psatpute@xxxxxxxx | |om) --- Comment #1 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-10-05 16:59:04 EDT --- Full review: 1. Please add a fontconfig file (fixed is monospace, that's easy) 2. Please correct the licensing tag, I doubt fixed uses 3 different licenses 3. Please remove Requires(pre): fontconfig BuildRequires: xorg-x11-font-utils (or tell me where they are used) 4. Please add a %build section (even if empty). rpm does not like specs without %build 5. Please put the URL in URL not in description (and limit your description line lenght to 80c) 6. Please compress the resulting pcf files 7. Why do you ship the Lucida license file ? 8. It would be neat to edit the readme so it does not references fonts not present in the rpm 9. it seems fontconfig reads the family name in the fonts as "MiscFixed". Please rename yout package ucs-miscfixed-fonts And that should be all -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review