Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526651 --- Comment #11 from Andrea Musuruane <musuruan@xxxxxxxxx> 2009-10-05 09:20:32 EDT --- I had a glance about the package. This is what else I noticed. * rpmlint /var/lib/mock/fedora-11-i386/result/*.rpm xpaint.src:246: W: macro-in-%changelog config xpaint-devel.i586: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. There are two occurences of % that haven't been escaped in the %changelog. Please fix them. * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: Packaging/Guidelines#parallelmake) * Duplicate BuildRequires: zlib-devel (by libpng-devel), libXpm-devel (by libXaw-devel), xorg-x11-proto-devel (by libXaw-devel), libSM-devel (by Xaw3d-devel), libXext-devel (by Xaw3d-devel) * Not end user documentation files installed: /usr/share/doc/xpaint-2.8.2/INSTALL Install instruction must not be installed /usr/share/doc/xpaint-2.8.2/Doc/CHANGES This changelog is so old that I really doubt it is useful /usr/share/doc/xpaint-2.8.2/Doc/Imakefile /usr/share/doc/xpaint-2.8.2/Doc/Makefile /usr/share/doc/xpaint-2.8.2/Doc/Makefile.bak 3 not documentation files. /usr/share/doc/xpaint-2.8.2/Doc/Operator.doc Developer file. /usr/share/doc/xpaint-2.8.2/Doc/sample.Xdefaults Maybe this is useful but because it will be the only useful file in this directory I think it will be better to move it to the parent dir. * Probably it is a good idea to include README.old among docs. Debian does this too. * There is no suggest in RPM therefore I think you should require gv, netpbm, lpr, xv, emacs Or otherwise make a README.Fedora file where you state what other program can be installed and why. "In the C Script Editor of XPaint, the External editor in the File menu will invoke <program_name>. The gs package will be needed for PDF/PS reading, netpbm will be needed for external conversion, lpr for printing. <ETC....> " * In the desktop file: Categories=Application;Graphics; is not good. Application is not a registered category: http://standards.freedesktop.org/menu-spec/latest/apa.html Please use: Graphics;2DGraphics;RasterGraphics; * Please use Mandriva description because it is more accurate (and based on author feedback too) http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/xpaint/current/SPECS/xpaint.spec?revision=452128&view=markup * Devel package is probably not needed and wrong. Xpaint uses some very strange C scripting. Without files you package in devel it cannot work. BTW, both Debian and Mandriva do not have a devel package. "The C script Editor can be used to write a script in language C, defining e.g. a programmable filter. This possibility will appeal to programmers who want to design their own filter routines. The "Compile" button compiles the C script as a shared ???.so library, and, if successful, links dynamically that library to Xpaint. Several examples will be found in the share/filters subdirectory. Notice that you can use this feature only if gcc has been installed on your system." * The following lines seem unneeded because both variables should be correctly set when invoking make. perl -p -i -e "s|CXXDEBUGFLAGS = .*|CXXDEBUGFLAGS = $RPM_OPT_FLAGS|" Makefile perl -p -i -e "s|CDEBUGFLAGS = .*|CDEBUGFLAGS = $RPM_OPT_FLAGS|" Makefile * You should probably patch Local.config to use "better" Fedora programs. This is what you can find there: EDITOR = emacs -fn 9x15 -cr green -ms red -bg lightyellow -fg black POSTSCRIPT_VIEWER = gv EXTERN_VIEWER = xv -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review