Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525211 --- Comment #12 from Jan Klepek <jan.klepek@xxxxxx> 2009-10-04 04:20:58 EDT --- (In reply to comment #11) > For -3: > > * License > - Well, actually it should be "GPLv3+ with exceptions", sorry. - fixed > * Local copy of system-wide files > - As rubygem-trollop is packaged seperately, this package > should not include %geminstdir/lib/trollop.rb . - oh, sorry, I must have somehow missed this in first place, fixed > * %files entry consideration > - As ditz script is installed under %_bindir (as symlink), > it is better that the corresponding man file is moved > to %_mandir/man1 (currently under %geminstdir/man) - not sure if i got the best solution... I'm gzipping man page and symlink it to %_mandir/man1, without gzip it create dangling symlink and move of manpage will corrupt gem structure. > - "INSTALL" file is probably not needed (this type of files > are usually needed for people to install a software by > themselves and not needed for people using rpm) > > - "Changelog" "LICENSE" and so on should correctly be > marked as %doc. - fixed Spec URL: http://hpejakle.fedorapeople.org/packages/rubygem-ditz.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/rubygem-ditz-0.5-4.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review