Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpaper - Library and tools for handling papersize https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207802 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2006-09-23 13:20 EST ------- I have spotted some more or less minor issues: * the man pages for functions should be in the devel package %{_mandir}/man3/* * removing unneded files rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la rm -rf $RPM_BUILD_ROOT%{_libdir}/*.a should be without -r and even maybe without f * I think that there is no need to set letter as a default, it is allready the default according to the man paperconf. In my opinion, what should be better is an empty file or a file with a comment along echo '# Simply write the paper name. See papersize(5) for possible values' > $RPM_BUILD_ROOT%{_sysconfdir}/papersize * in man paperconfig there is a reference to /etc/libpaper.d * The file NEWS in debian/ should certainly be in %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review