Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526866 --- Comment #3 from Christoph Wickert <cwickert@xxxxxxxxxxxxxxxxx> 2009-10-02 20:19:43 EDT --- OK - MUST: rpmlint is silent: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/torium-* 3 packages and 0 specfiles checked; 0 errors, 0 warnings. OK - MUST: named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package %{name} OK - MUST: package meets the Packaging Guidelines OK - MUST: Fedora approved license and meets the Licensing Guidelines: ISC OK - MUST: license field in spec file matches the actual license OK - MUST: license file included in %doc OK - MUST: spec is in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by MD5 fa1980cef7e248dbd82526f247541442 OK - MUST: successfully compiles and builds into binary rpms on x86_64 N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. OK - MUST: all build dependencies are listed in BuildRequires. N/A - MUST: handles locales properly with %find_lang N/A - MUST: every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review OK - MUST: owns all directories that it creates (none) OK - MUST: no duplicate files in the %files listing OK - MUST: Permissions on files are set properly, includes %defattr(...) OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT. FIX - MUST: macro usage not consistent, you are mixing different styles OK - MUST: package contains code, or permissible content N/A - MUST: Large documentation files should go in a -doc subpackage OK - MUST: Files included as %doc do not affect the runtime of the application OK - MUST: Header files must be in a -devel package N/A - MUST: Static libraries must be in a -static package N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A - MUST: If a package contains library files with a suffix, then library files that end in .so must go in a -devel package. N/A - MUST: devel packages must require the base package using a fully versioned dependency OK - MUST: The package does not contain any .la libtool archives. OK - MUST: The package contains a GUI application and includes a %{name}.desktop file, and that file is properly installed with desktop-file-install in the %install section. OK - MUST: packages does not own files or directories already owned by other packages. OK - MUST: at the beginning of %install, the package runs rm -rf $RPM_BUILD_ROOT. OK - MUST: all filenames valid UTF-8 SHOULD Items: OK - SHOULD: Source package includes license text(s) as a separate file. N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. OK - SHOULD: builds in mock. OK - SHOULD: compiles and builds into binary rpms on all supported architectures. OK - SHOULD: functions as described. OK - SHOULD: Scriptlets are sane. N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. N/A - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg N/A - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Other items: OK - latest stable version OK - SourceURL valid OK - Fedora specific compiler flags honored OK - Debuginfo complete Issues: - You are using both $RPM_BUILD_ROOT and %{buildroot}, please only use one for consistency. - No need to remove the flags as the flag policy was revoked. If you want to remove them, make a -flags subpackage. - Timestamp of Source0 does not match. Although this is minor I'd like to ask you to download it again and keeping the timestamps intact, see https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps - I'm not happy with the desktop file: "Encoding" is obsolete and IMO the app should also been shown in KDE. And it should hate FileTransfer as additional category to allow nested menus. You can fix this in the spec with desktop-file-install \ --delete-original \ --add-category=FileTransfer \ --remove-key=Encoding \ --remove-key=NotShowIn \ --dir=%{buildroot}%{_datadir}/applications \ %{buildroot}/%{_datadir}/applications/torium.desktop Note: During %configure I see - ./configure: line 5288: gconftool-2: command not found although gconf is not needed: I guess this is just a relict of borrowing the Makefile from another package, so we ignore it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review