Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526738 Steve Traylen <steve.traylen@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |steve.traylen@xxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |steve.traylen@xxxxxxx Flag| |fedora-review? --- Comment #1 from Steve Traylen <steve.traylen@xxxxxxx> 2009-10-01 15:17:03 EDT --- Hi, 1) $ rpmlint py-radix.spec py-radix.spec:28: W: setup-not-quiet py-radix.spec: E: no-cleaning-of-buildroot %install %setup needs a -q and first line of install should be rm -rf $RPM_BUILD_ROOT 2) The release should have a dist tag. i.e https://fedoraproject.org/wiki/Packaging/DistTag 3) There is no need to have Requires: python since it is automatically worked out. https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review