Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225617 --- Comment #16 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> 2009-09-30 18:40:37 EDT --- I need to look at it some more (got distracted by other bug requests, and this is a complex package), however here are some remarks 1. rpm will evaluate your %global even with # (why did you want to comment it out?) 2. common_desc should be a global too 3. your -fixed subpackage contains font files that declare themselves as "Console". These should go in a "console" subpackage 4. not too sure if it'd be better to move console8x8 in its own subpackage or just rename or remap it (cf remapping template) 5. You can drop the duplicated Group: Applications/System lines, the main one will be inherited in modern rpm 6. why do you add a Requires(pre): fontconfig ? We do not require fontconfig in font packages. Do you have a special need? 7. what do you need xorg-x11-font-utils as BR for ? 8. I think you can specify a different LICENSE field per subpackage, can you check with spot how he'd prefer the licensing reported ? (mixed licensing packages are a PITA) I feel if it'd be better if each subpackage was tagged with just the necessary license info (and included the corresponding license files) 9. fontconfig will happily use pcf.gz files, please compress your pcf files (if you're feeling ambitious ask behdad if he intends to support pcf.xz soon) That's all for this first partial review, will look more in depth tomorrow -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review