Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ruby-racc - LALR(1) Parser Generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207292 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-23 01:48 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. OK - License (LGPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: c23ee98abe79f051243adf04d4a82900 racc-1.4.5-all.tar.gz c23ee98abe79f051243adf04d4a82900 racc-1.4.5-all.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. See below - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: OK - Should include License or ask upstream to include it. OK - Should build in mock. (fc6 {i386|x86_64}) Issues: 1. Minor issue: Might change: %defattr(-,root,root) to %defattr(-,root,root,-) Otherwise it looks good, so this package is APPROVED. Don't forget to close this bug as NEXTRELEASE once it's been imported and built. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review