Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: farsight - A audio/video conferencing framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=207141 kevin@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kevin@xxxxxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From kevin@xxxxxxxxx 2006-09-23 01:11 EST ------- OK - Package name OK - Spec file matches base package name. OK - Meets Packaging Guidelines. See below - License (GPL) See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 68daa710087201064680fd02c8a4951a farsight-0.1.8.tar.gz 68daa710087201064680fd02c8a4951a farsight-0.1.8.tar.gz.1 OK - Package compiles and builds on at least one arch. OK - BuildRequires correct OK - Spec has needed ldconfig in post and postun OK - Package owns all the directories it creates. OK - Package has no duplicate files in %files. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Spec has consistant macro usage. OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Headers/static libs in -devel subpackage. OK - .pc files in -devel subpackage. OK - .so files in -devel subpackage. OK - -devel package Requires: %{name} = %{version}-%{release} OK - .la files are removed. OK - Package doesn't own any directories other packages own. OK - No rpmlint output. SHOULD Items: See below - Should include License or ask upstream to include it. OK - Should build in mock. (fc6 {i386|x86_64}) Issues: 1. Is the License LGPL or GPL? The spec says GPL, but the COPYING file is the LGPL, and all the source files refer to LGPL. 2. Are all the disables needed? Or could some of them be enabled if other packages were in extras? --disable-sequence-diagrams \ --disable-sofia-sip \ --disable-gnet \ --disable-msnwebcam \ --disable-yahoowebcam \ 3. rpmlint says: W: farsight-devel no-documentation which can be ignored. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review