Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: TurboKid - Python template plugin that supports Kid templates https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=206839 ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2006-09-23 00:04 EST ------- MD5Sums: 59c0ee439ad02613965017e38b6796d0 TurboKid-0.9.8-2.src.rpm 35997fd4208f40279461b6a823a4e03f TurboKid-0.9.8-py2.4.egg f7a9046bb1d065aa13fad23ba6363018 TurboKid.spec Blockers: * As we discussed on IRC the naming is better as python-turbogears. * Upstream seems to have changed the download URL to: http://files.turbogears.org/eggs/TurboKid-0.9.8-py2.4.egg * Package needs to own the %{python_sitelib}/turbokid directory. Removing the (*) from the relevant line in %files should take care of that. * We should try to place the EGG-INFO directory into the site-packages directory so that setuptools realizes we have it installed. From our IRC conversation it sounds like you have a better idea of how this should look than I do :-) Good: * Package licensed under a MIT style license. * The spec file is legible, American English. * Source matches upstream. * Package compiles and builds as noarch on an x86_64. * All BuildRequires are satisfied. * No locales. * No shared libraries, static libraries, headers, or pkgconfig files. * Not relocatable. * No duplicate files. * Permissions properly set. * Proper %clean section. * Macros are properly used. * No large docs. Docs do not affect runtime. * No GUI application. * Does not own directories already owned. * Builds in mock * rpmlint -i TurboKid-0.9.8-2.noarch.rpm W: TurboKid no-documentation Hopefully upstream will include more documentation in the future. Not Yet checked: * Tested that it works. I have to build a new TurboGears package to test this with. If you fix the blockers, I'll get TurboGears built so I can test and we can get this approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review