Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525814 Adel Gadllah <adel.gadllah@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2009-09-26 04:07:17 EDT --- (In reply to comment #2) > Thanks for reviewing! > > (In reply to comment #1) > > 1) The name might be missleading as it isn't really fusecompress1 but kind of a > > migration tool, fusecompress1-migrate would be approriate to avoid confusion. > > How about fusecompress_offline1 since that's the name of the utility it > installs? Yeah that makes sense. > > 2) Use install rather than mv > > mv is being used to rename two files that were installed by make install. > (renaming the binary from fusecompress_offline to fusecompress_offline1 and the > man page from fusecompress_offline.1 to fusecompress_offline1.1) This seems > proper to me. Do you agree or is there some way to use install in that > situation that's better? Sure as this is already installed using install again does not make much sense. > > 3) Well the rpmlinit messages is clear, remove the +x from the source files. > > Fixed > > SPEC: http://toshio.fedorapeople.org/packages/fusecompress_offline1.spec > SRPM: > http://toshio.fedorapeople.org/packages/fusecompress_offline1-1.99.19-6.fc11.src.rpm > > http://koji.fedoraproject.org/koji/taskinfo?taskID=1708383 Looks good now, "- Use install instead of mv" well you didn't do that but a changelog entry isn't a blocker ;) => APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review