Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525808 --- Comment #2 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2009-09-25 19:13:12 EDT --- (In reply to comment #1) > Good: > * Naming follows the packaging guidelines > * license is contained in README and README is included in the documentation > * Spec file is readable > * Source matches with source from canonical upstream > * No locales > * Not a library > * No bundled libraries > * Not relocatable > * Directories created by package and no others are owned > * No duplicate files listed > * Permissions set properly > * Proper %clean > * Macros used consistently > * Code, not content > * No %doc files affect program runtime > * No subpackages > * Not a GUI app > * rm -rf run properly at beginning of %install > * Filenames are valid utf-8 > * Package builds in koji > * rpmlint clean > * Tested that pigz compresses a file that can be decompressed by gzip and > vice versa > > Needswork: > * license should be "zlib" oh ok. > Providing you change the license when you import the package, this package is > APPROVED. Sure, thanks for the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review