Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525814 Adel Gadllah <adel.gadllah@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adel.gadllah@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |adel.gadllah@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Adel Gadllah <adel.gadllah@xxxxxxxxx> 2009-09-25 18:34:10 EDT --- ============= REVIEW ============= [+] source files match upstream: 2e52d68a5f7f127c075a79b9ff3c26c9d9ebbd7b [1] package meets naming and versioning guidelines. [2] specfile is properly named, is cleanly written and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible: GPLv2 [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] %clean is present. [+] package builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1708170 [+] package installs properly. [3] rpmlint is silent: fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformTable.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/ByteOrder.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/LayerMap.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Lock.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileHeader.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/main_offline.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Compress.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/File.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformNONE.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileUtils.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressBZ2.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Transform.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRaw.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressLZO.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Memory.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRememberTimes.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Compress.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressBZ2.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformNONE.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/CompressedTable.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRawCompressed.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressLZO.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRememberTimes.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRawNormal.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/minilzo/minilzo.c fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRawNormal.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/File.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformXOR.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/minilzo/lzoconf.h fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Block.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/CompressedTable.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FuseCompress.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformXOR.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Mutex.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileRawCompressed.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Memory.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/CompressedMagic.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileUtils.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressGZ.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/LinearMap.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/LayerMap.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompress.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/CompressedMagic.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileHeader.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FuseCompress.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/Block.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/LinearMap.hpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileManager.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformTable.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompress.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/TransformCompressGZ.cpp fusecompress1-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/fusecompress-1.99.19/src/FileManager.hpp 3 packages and 1 specfiles checked; 0 errors, 52 warnings. [+] final provides and requires are sane: fusecompress1 = 1.99.19-5.fc12 fusecompress1(x86-64) = 1.99.19-5.fc12 ---- fuse libbz2.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) libfuse.so.2()(64bit) libfuse.so.2(FUSE_2.6)(64bit) libfuse.so.2(FUSE_2.8)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libpthread.so.0()(64bit) libpthread.so.0(GLIBC_2.2.5)(64bit) librlog.so.5()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.11)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) libz.so.1()(64bit) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) rpmlib(PayloadIsXz) <= 5.2-1 [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [3] file permissions are appropriate. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [+] no libtool .la droppings. ============= COMMENTS ============= 1) The name might be missleading as it isn't really fusecompress1 but kind of a migration tool, fusecompress1-migrate would be approriate to avoid confusion. 2) Use install rather than mv 3) Well the rpmlinit messages is clear, remove the +x from the source files. Besides this the package looks good to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review