Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=519512 Martin Gieseking <martin.gieseking@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #11 from Martin Gieseking <martin.gieseking@xxxxxx> 2009-09-25 16:28:21 EDT --- (In reply to comment #10) > With respect to comment 8, I prefer to have all the BRs in one place because > then I can easily see what I need to build. Let's chalk that one up to > personal taste. Thank you very much for the thorough review. That's absolutely OK for me, and you're welcome. > With respect to comment 9, now I'm really confused. I added that because of > the problem you noted in comment 1 and comment 4. I never saw that problem > myself. So are you saying that it disappeared as mysteriously as it appeared? > That makes me nervous.... Yes that's strange. When I built the package yesterday, the flags were set properly without an explicit %attr prefix. I can't reproduce the problem at the moment... > If the package now meets with your approval, can you set the fedora-review flag > to +? Sure. ------------------------ The package is APPROVED. ------------------------ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review