Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525151 --- Comment #10 from Mario Basic <mario@xxxxxxxxxxxxxxxxxx> 2009-09-25 04:46:58 EDT --- (In reply to comment #8) > > make CFLAGS="${RPM_OPT_FLAGS}" CLconverter > would have been it. > > > 5.done > You seem to have rebuilt the tarball without incrementing the version. > A reasonable upstream increments the version each time it releases a new > tarball, because people are checking tarballs for changes and will yell at you > when a tarball is being replaced without incrementing the version. > > BTW1: Did you consider to add a Makefile to your package? It would help > packagers of various distros and OSes, and assist them to avoid having to > figure out how your package is supposed to be built. > > BTW2: Do you have another package on review? Based on this package review > alone, I am not yet sufficiently convinced about your packaging expertise to > sponsor you. I've changed the spec file to use make CFLAGS="${RPM_OPT_FLAGS}" CLconverter. Totally forgotten about changing the version. Will look into how to create a Makefile. I have done it once before but forgotten. No, this one only, yet. (In reply to comment #9) > A few additional remarks from me: :) > > - the license tag must be GPLv3+ (because of the addition "or > (at your option) any later version" in the source headers) > > - the given URL doesn't seem to be up-to-date (404) > > - append the CFLAGS assignment to the make statement: > make CLconverter CFLAGS="${RPM_OPT_FLAGS}" > > - in %files, replace %defattr(-,root,root) by %defattr(-,root,root,-) > > - you should add a changelog entry with a short summary about the changes for > each revision, so that the file history can be reproduced > > - change the file permissions of the tarball to 0644 > > > $ rpmlint /var/lib/mock/fedora-11-x86_64/result/CLconverter-* > CLconverter.src: W: strange-permission CLconverter-0.4.7.tar.gz 0755 > CLconverter-debuginfo.x86_64: E: debuginfo-without-sources > 3 packages and 0 specfiles checked; 1 errors, 1 warnings. I've changed the license tag. URL to the new files is below. I've used the suggestion from comment #8 to set the CFLAGS. I have replaced %defattr(-,root,root) to %defattr(-,root,root,-). SPEC URL: http://www.information-hq.org/download/projects/CLconverter/Spec/CLconverter.spec SRPM URL: http://www.information-hq.org/download/projects/CLconverter/Srpm/CLconverter-0.4.8-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review