Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475861 Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |michael.silvanus@xxxxxxxxx Flag| |fedora-review? --- Comment #7 from Michel Alexandre Salim <michael.silvanus@xxxxxxxxx> 2009-09-24 21:26:52 EDT --- SRPM needs to be updated, spec is at 0.16-2 MUST ? rpmlint SRPM not available yet OK package name OK spec file name OK package guideline-compliant OK license complies with guidelines FIX license field accurate some files, e.g. Tools/gclose.m and many other Tools/, are GPLv3+ some files are LGPLv3+: $ grep -rl "version 3" `grep -rl "GNU Lesser" *` configure.ac COPYING Headers/Additions/GNUstepGUI/GSVersion.h.in Source/NSMenuItem.m Source/tiff.m Perhaps separate the library into a separate -libs subpackage, which can then be LGPLv2+ and LGPLv3+, and the rest can then be GPLv2+ and GPLv3+? (see Documentation/readme.texi) -doc subpackage should be GFDL. The license file, Documentation/manual/LICENSE should be included in %files doc. Also, %{_datadir}/GNUstep/Documentation/* should be marked as %doc as well. OK license file not deleted OK spec in US English FIX spec legible "gui" in summary and descriptions should perhaps be capitalized ? source matches upstream SRPM not available • builds under >= 1 archs, others excluded OK build dependencies complete can drop gnustep-make, as gnustep-base-devel requires it OK library -> ldconfig OK own all directories OK no dupes in %files • permission OK %clean RPM_BUILD_ROOT OK macros used consistently OK Package contains code OK large docs => -doc OK doc not runtime dependent OK headers in -devel OK if contains *.pc, req pkgconfig GNUstep variation: if containing Makefiles, req gnustep-make OK if libfiles are suffixed, the non-suffixed goes to devel OK devel requires versioned base package note: does not need gnustep-make directly, but it's OK to be explicit OK clean buildroot before install OK filenames UTF-8 SHOULD FIX if license text missing, ask upstream to include it license file for LGPLv3+ and GPLv2+ missing • package build in mock on all architectures • package functioned as described OK scriplets are sane OK other subpackages should require versioned base OK require package not files Summary: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review